Re: [HACKERS] pg_ls_waldir() & pg_ls_logdir()

On Mon, Feb 20, 2017 at 6:21 AM, Dave Page <dpage@pgadmin.org> wrote:
> Patch includes the code and doc updates.

Review:

+        strftime(mtime, 25, "%Y-%m-%d %H:%M:%S %Z",
localtime(&(attrib.st_ctime)));
+        const int n = snprintf(NULL, 0, "%lld", attrib.st_size);
+        char size[n+1];
+        snprintf(size, n+1, "%lld", attrib.st_size);

We don't allow variable declarations in mid-block.  You've been
programming in C++ for too long!

The documentation should be updated to say that access to
pg_ls_logdir() and pg_ls_waldir() can be granted via the permissions
system (see the paragraph above the table you updated).

The four existing functions in the documentation table each have a
corresponding paragraph below the table, but the two new functions you
added don't.

+1 for the concept.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company