Re: [COMMITTERS] pgsql: Add DISCARD SEQUENCES command.

On Thu, Oct 3, 2013 at 6:38 PM, Kevin Hale Boyes <kcboyes@gmail.com> wrote:
> My C is very rusty but the traversal of SeqTableData doesn't seem correct.
> It saves the seqtab->next pointer into next, frees seqtab and then
> dereferences it.
> Shouldn't that last line be: seqtab = next?
>
> Kevin.
>
> +/*
> + * Flush cached sequence information.
> + */
> +void
> +ResetSequenceCaches(void)
> +{
> +   SeqTableData *next;
> +
> +   while (seqtab != NULL)
> +   {
> +       next = seqtab->next;
> +       free(seqtab);
> +       seqtab = seqtab->next;
> +   }

Oops, good catch.  Will fix, thanks.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company