Re: open items for 9.4

On Mon, Sep 29, 2014 at 2:44 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Robert Haas <robertmhaas@gmail.com> writes:
>> The items I see are:
>
>> - Remove xloginsert_slots/xloginsert_locks GUC - Not yet!!
>
>> The text seems to indicate that there's some disagreement on this
>> point.  I don't have a strong opinion on whether or not to keep the
>> GUC, but if we're going to remove it it should probably happen before
>> beta3.  It's going to be impossible to remove once we've released with
>> it, I suspect.
>
> The lack of any documentation for the GUC (neither in config.sgml or
> postgresql.conf.sample) suggests very very strongly that it was not
> meant to be shipped.  If we don't remove it I will certainly insist
> that it be documented adequately.
>
> Personally I think a hardwired #define should be plenty.  What's the
> argument that users will need to tune this at runtime?

+1.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company