Re: pgsql: Fix minor problems with non-exclusive backup cleanup.
| От | Robert Haas |
|---|---|
| Тема | Re: pgsql: Fix minor problems with non-exclusive backup cleanup. |
| Дата | |
| Msg-id | CA+TgmoaHJoYy+N5+0prqo5xuBNrQ5-KtW_Vmnm+Wgg84aC3GPg@mail.gmail.com обсуждение исходный текст |
| Ответ на | Re: pgsql: Fix minor problems with non-exclusive backup cleanup. (Tom Lane <tgl@sss.pgh.pa.us>) |
| Ответы |
Re: pgsql: Fix minor problems with non-exclusive backup cleanup.
|
| Список | pgsql-committers |
On Thu, Aug 6, 2020 at 2:19 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Robert Haas <rhaas@postgresql.org> writes:
> > Fix minor problems with non-exclusive backup cleanup.
>
> Seems like there's an extra space in this error message in
> do_pg_abort_backup:
>
> + if (emit_warning)
> + ereport(WARNING,
> + (errmsg("aborting backup due to backend exiting before pg_stop_back up was called")));
Ah, crap. Peter fixed that before, and I forgot to include it when
back-patching.
> Also, while I'm bugging you: it wasn't quite clear from the thread
> whether this is alone sufficient to fix the user-visible issue
> reported by Bharath Rupireddy, or whether we still need to change
> the JIT logic as well to do that.
I believe it suffices, but see also the commit I pushed to master.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
В списке pgsql-committers по дате отправления: