Re: [PATCH v2] use has_privs_for_role for predefined roles

On Sat, Apr 2, 2022 at 1:32 PM Joe Conway <mail@joeconway.com> wrote:
> I saw that Robert added documentation and it already reads correctly I
> believe, except possibly an unrelated issue:
>
> 8<--------------
>       <para>
>        A role which replication whose privileges users are required to
> possess
>        in order to make use of the <literal>shell</literal> backup target.
>        If this is not set, any replication user may make use of the
>        <literal>shell</literal> backup target.
>       </para>
> 8<--------------
>
> Robert, should that actually be:
>   s/role which replication/role with replication/

Oh, good catch. Actually shouldn't "with replication" just be deleted?

Or maybe it needs to be reworded more, for clarity: "Replication users
must possess the privileges of this role in order to ..."

-- 
Robert Haas
EDB: http://www.enterprisedb.com