object_classes array is broken, again
От | Robert Haas |
---|---|
Тема | object_classes array is broken, again |
Дата | |
Msg-id | CA+Tgmoa6SgDaxW_n_7SEhwBAc=mniYga+obUj5fmw4rU9_mLvA@mail.gmail.com обсуждение исходный текст |
Ответы |
Re: object_classes array is broken, again
Re: object_classes array is broken, again Re: object_classes array is broken, again |
Список | pgsql-hackers |
The transforms patch seems to have forgotten to add TransformRelationId to object_classes[], much like the RLS patch forgot to add PolicyRelationId in the same place. Fixing this is easy, but ISTM that we need to insert some sort of a guard to prevent people from continuing to forget this, because it's apparently quite easy to do. Perhaps add_object_address should Assert(OidIsValid(object_classes[oclass])), plus a (static?) assert someplace checking that OidIsValid(object_classes[MAX_OCLASS - 1])? -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company
В списке pgsql-hackers по дате отправления: