Re: Patch review for logging hooks (CF 2012-01)
| От | Robert Haas |
|---|---|
| Тема | Re: Patch review for logging hooks (CF 2012-01) |
| Дата | |
| Msg-id | CA+TgmoZw6y3zYZ5ude3=qd6CebAXvZzTKf8fJumhcbXj8wjmgw@mail.gmail.com обсуждение исходный текст |
| Ответ на | Re: Patch review for logging hooks (CF 2012-01) (Greg Smith <greg@2ndQuadrant.com>) |
| Ответы |
Re: Patch review for logging hooks (CF 2012-01)
Re: Patch review for logging hooks (CF 2012-01) |
| Список | pgsql-hackers |
On Fri, Jan 20, 2012 at 2:47 AM, Greg Smith <greg@2ndquadrant.com> wrote: >> The updated patch looks good, marking as 'Ready for Committer' > > Patches without documentation are never ready for commit. For this one, I'm > not sure if that should be in the form of a reference example in contrib, or > just something that documents that the hook exists and what the ground rules > are for grabbing it. Hooks are frequently not documented, and we only sometimes even bother to include an example in contrib. We should probably at least have a working example for testing purposes, though, whether or not we end up committing it. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company
В списке pgsql-hackers по дате отправления: