Re: Incorrectly reporting config errors

On Tue, Jan 21, 2014 at 1:59 PM, Thom Brown <thom@linux.com> wrote:
> On 21 January 2014 18:35, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Thom Brown <thom@linux.com> writes:
>>> I'm getting a report of a config error when changing a config value
>>> that requires a restart:
>>> ...
>>> 2014-01-21 18:14:53 GMT [28718]: [4-1] user=,db=,client= LOG:
>>> received SIGHUP, reloading configuration files
>>> 2014-01-21 18:14:53 GMT [28718]: [5-1] user=,db=,client= LOG:
>>> parameter "max_connections" cannot be changed without restarting the
>>> server
>>> 2014-01-21 18:14:53 GMT [28718]: [6-1] user=,db=,client= LOG:
>>> configuration file "/home/thom/Development/data/postgresql.conf"
>>> contains errors; unaffected changes were applied
>>
>>> It doesn't contain errors.
>>
>> Yeah it does: it's got a value that can't be applied.  I think you're
>> making a semantic quibble.
>
> I see it as technically wrong.  There's nothing wrong with my config
> file.  A reload of the file may not be able to apply all the settings,
> but there's no typo or mistake anywhere in my file.  I would just need
> to restart instead of reload.
>
> However, given that you find it unsurprising, I'll leave it there.

I kind of agree with Thom.  I understand why it's doing what it's
doing, but it still seems sort of lame.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company