Re: initdb: Improve error recovery.
От | Robert Haas |
---|---|
Тема | Re: initdb: Improve error recovery. |
Дата | |
Msg-id | CA+TgmoZ_XcTOL2K1sv3aMfXe3Xxo4WE1cbp9i1vH0DiVsaJg4g@mail.gmail.com обсуждение исходный текст |
Ответ на | initdb: Improve error recovery. (Mats Erik Andersson <bsd@gisladisker.se>) |
Список | pgsql-hackers |
On Thu, Nov 27, 2014 at 7:28 AM, Mats Erik Andersson <bsd@gisladisker.se> wrote: > I would like to improve error recovery of initdb when the > password file is empty. The present code declares "Error 0" > as the cause of failure. It suffices to use ferrer() since > fgets() returns NULL also at a premature EOF. > > In addition, a minor case is the need of a line feed in > order to print the error message on a line of its own > seems desirable. > > Best regards, > Mats Erik Andersson Please add your patch here so that it doesn't get forgotten about: https://commitfest.postgresql.org/action/commitfest_view/open Also, note that the PostgreSQL project prefers for patches to be attached rather than inline, as mailers have a tendency to mangle them. Thanks, -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company
В списке pgsql-hackers по дате отправления: