Re: refactoring basebackup.c

On Mon, Jan 3, 2022 at 12:12 PM tushar <tushar.ahuja@enterprisedb.com> wrote:
> On 11/22/21 11:05 PM, Jeevan Ladhe wrote:
> > Please find the lz4 compression patch here that basically has:
> Please refer to this  scenario , where --server-compression is only
> compressing
> base backup into lz4 format but not pg_wal directory
>
> [edb@centos7tushar bin]$ ./pg_basebackup -Ft --server-compression=lz4
> -Xstream -D foo
>
> [edb@centos7tushar bin]$ ls foo
> backup_manifest  base.tar.lz4  pg_wal.tar
>
> this same is valid for gzip as well if server-compression is set to gzip
>
> edb@centos7tushar bin]$ ./pg_basebackup -Ft --server-compression=gzip4
> -Xstream -D foo1
>
> [edb@centos7tushar bin]$ ls foo1
> backup_manifest  base.tar.gz  pg_wal.tar
>
> if this scenario is valid then both the folders format should be in lz4
> format otherwise we should
> get an error something like - not a valid option ?

Before sending an email like this, it would be a good idea to read the
documentation for the --server-compression option.

-- 
Robert Haas
EDB: http://www.enterprisedb.com