Re: [PATCH] Make pg_basebackup configure and start standby [Review]

On Wed, Oct 10, 2012 at 8:02 PM, Fujii Masao <masao.fujii@gmail.com> wrote:
> On Thu, Oct 11, 2012 at 3:36 AM, Boszormenyi Zoltan <zb@cybertec.at> wrote:
>> 2012-10-10 18:23 keltezéssel, Fujii Masao írta:
>>> When tar output format is specified together with -R option, recovery.conf
>>> is
>>> not included in base.tar. I think it should.
>>
>>
>> Why? This patch only promises to write the recovery.conf into the
>> directory specified with -D.
>
> Because it's more user-friendly. If recovery.conf is not included in base.tar,
> when base.tar is extracted to disk to use the backup, a user always needs
> to copy recovery.conf to the extracted directory. OTOH if it's included in
> base.tar, such copy operation is not required and we can simplify the
> procedures to use the backup a bit.

+1.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company