Re: abi-compliance-check failure due to recent changes to pg_{clear,restore}_{attribute,relation}_stats()

On Mon, Oct 20, 2025 at 3:34 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Nathan Bossart <nathandbossart@gmail.com> writes:
> > Here is an updated patch set.
>
> The v3 patches work for me.
>
> BTW, not critical right now, but thought I'd mention it: ISTM
> this mechanism obviates the need for the single-purpose NodeTag ABI
> checks installed by commit eea9fa9b2.  We still need the checks in
> gen_node_support.pl to ensure that the makefiles and meson files
> build things the same way, but we shouldn't need the parts that were
> intended to prevent accidental ABI changes in the back branches.
> Since that stuff requires nonzero manual maintenance, I plan to get
> rid of it once we're satisfied that the ABI checker is working well.

Hmm, but: the code in gen_node_support.pl would tell you about trouble
before you committed, whereas the ABI checks would only tell you about
trouble after you commit. It seems to me that we are in desperate need
of reducing, rather than increasing, the number of mistakes you can
make and find out about only after commit.

--
Robert Haas
EDB: http://www.enterprisedb.com