Re: Changing recovery.conf parameters into GUCs

On Thu, Mar 28, 2013 at 11:48 AM, Simon Riggs <simon@2ndquadrant.com> wrote:
> What we want to do is make recovery parameters into GUCs, allowing
> them to be reset by SIGHUP and also to allow all users to see the
> parameters in use, from any session.
>
> The existing mechanism for recovery is that
> 1. we put parameters in a file called recovery.conf
> 2. we use the existence of a recovery.conf file to trigger archive
> recovery/replication
>
> I also wish to see backwards compatibility maintained, so am proposing
> the following:
>
> a)  recovery parameters are made into GUCs (for which we have a patch
> from Fujii)
> b)  all processes automatically read recovery.conf as the last step in
> reading configuration files, if it exists, even if data_directory
> parameter is in use (attached patch)
> c)  we trigger archive recovery by the presence of either
> recovery.conf or recovery.trigger in the data directory. At the end,
> we rename to recovery.done just as we do now. This means that any
> parameters put into recovery.conf will not be re-read when we SIGHUP
> after end of recovery. Note that recovery.trigger will NOT be read for
> parameters and is assumed to be zero-length.
> (minor patch required)

I still prefer Greg Smith's proposal.

http://www.postgresql.org/message-id/4EE91248.8010505@2ndQuadrant.com

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company