Re: [HACKERS] renaming pg_resetxlog to pg_resetwal has broken pg_upgrade.

On Tue, Feb 14, 2017 at 5:13 PM, Michael Paquier
<michael.paquier@gmail.com> wrote:
> On Wed, Feb 15, 2017 at 3:55 AM, Jeff Janes <jeff.janes@gmail.com> wrote:
>> I thought people would object to checking the version number in two
>> different places to make the same fundamental decision, and would want that
>> refactored somehow.  But if you are OK with it, then I am.
>
> The binary versions are checked only once, which does not with change
> HEAD. With this patch it happens just earlier, which makes the most
> sense now that we have a condition depending on the version of what is
> installed.

Thanks, Michael!  Committed.

I actually thought about this problem when I committed the original
patch but decided it ought to be OK because I didn't see why we'd be
running pg_resetxlog on the old cluster.  I didn't think about the
fact that we might be running it with the -n option.  Oops.

Thanks Jeff for the report.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company