Re: [HACKERS] Update comment in ExecPartitionCheck

On Tue, Jul 4, 2017 at 4:55 AM, Etsuro Fujita
<fujita.etsuro@lab.ntt.co.jp> wrote:
> This comment in an error handling in ExecPartitionCheck():
>
>     if (!ExecCheck(resultRelInfo->ri_PartitionCheckExpr, econtext))
>     {
>         char       *val_desc;
>         Relation    orig_rel = rel;
>
>         /* See the comment above. */
>         if (resultRelInfo->ri_PartitionRoot)
>
> should be updated because we don't have any comment on that above in the
> code.  Since we have a comment on that in ExecConstraints() defined just
> below that function, I think the comment should be something like this: "See
> the comment in ExecConstraints().".  Attached is a patch for that.

Hrm.  I'm not sure I understand which comment in ExecConstraints()
this is supposed to refer to.  Maybe we need to think a bit harder
about how to make this clear.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company