Re: Should extension--unpackaged-$ver.sql's \echo use FROM unpackaged;?

On Thu, Jul 3, 2014 at 9:03 AM, Fujii Masao <masao.fujii@gmail.com> wrote:
> On Thu, Jul 3, 2014 at 4:26 AM, Andres Freund <andres@2ndquadrant.com> wrote:
>> Hi,
>> Fujii noticed that I'd used
>> \echo Use "CREATE EXTENSION pg_buffercache" to load this file. \quit
>> in an extension upgrade script. That's obviously wrong, because it
>> should say ALTER EXTENSION. The reason it's that way is that I copied
>> the line from the unpackaged--1.0.sql file.
>> I noticed all unpackaged--$version transition files miss the "FROM
>> unpackaged" in that echo.
>> I guess that's just a oversight which we should correct?
>
> Maybe for user-friendness. But I think that's not so important fix enough
> to backpatch.

Seems like a clear mistake to me.  +1 for fixing it and back-patching.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company