Re: pg_upgrade broken by xlog numbering

On Mon, Jun 25, 2012 at 8:11 AM, Kevin Grittner
<Kevin.Grittner@wicourts.gov> wrote:
> On HEAD at the moment, `make check-world` is failing on a 32-bit Linux
> build:

This appears to be because of the following hunk from commit
dfda6ebaec6763090fb78b458a979b558c50b39b:

@@ -558,10 +536,10 @@ PrintControlValues(bool guessed)       snprintf(sysident_str, sizeof(sysident_str),
UINT64_FORMAT,                       ControlFile.system_identifier);
 

-       printf(_("First log file ID after reset:        %u\n"),
-                  newXlogId);
-       printf(_("First log file segment after reset:   %u\n"),
-                  newXlogSeg);
+       XLogFileName(fname, ControlFile.checkPointCopy.ThisTimeLineID, newXlogSe
+
+       printf(_("First log segment after reset:        %s\n"),
+                  fname);       printf(_("pg_control version number:            %u\n"),
ControlFile.pg_control_version);      printf(_("Catalog version number:               %u\n"),
 

Evidently, Heikki failed to realize that pg_upgrade gets the control
data information by parsing the output of pg_controldata.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company