On Tue, Mar 8, 2016 at 12:59 PM, Masahiko Sawada <sawada.mshk@gmail.com> wrote:
>> How about instead changing things so that we specifically reject
>> indexes? And maybe some kind of a check that will reject anything
>> that lacks a relfilnode? That seems like it would be more on point.
>
> I agree, I don't have strong opinion about this.
> It would be good to add condition for rejecting only indexes.
> Attached patches are,
> - Change heap2 rmgr description
> - Add condition to pg_visibility
> - Fix typo in pgvisibility.sgml
> (Sorry for the late notice..)
OK, committed the first and last of those. I think the other one
needs some work yet; the error message doesn't seem like it is quite
our usual style, and if we're going to do something here we should
probably also insert a check to throw a better error when there is no
relfilenode.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company