Re: BitmapHeapScan streaming read user and prelim refactoring

On Thu, Mar 14, 2024 at 9:00 AM Heikki Linnakangas <hlinnaka@iki.fi> wrote:
> The portal code is pretty explicit about it, the ExecutorRun() call in
> PortalRunSelect() looks like this:
>
>              PushActiveSnapshot(queryDesc->snapshot);
>              ExecutorRun(queryDesc, direction, (uint64) count,
>                          portal->run_once);
>              nprocessed = queryDesc->estate->es_processed;
>              PopActiveSnapshot();
>
> I looked at all the callers of ExecutorRun(), and they all have the
> active snapshot equal to queryDesc->snapshot, either because they called
> CreateQueryDesc() with the active snapshot before ExecutorRun(), or they
> set the active snapshot like above.

Well, maybe there's a bunch of code cleanup possible, then.

--
Robert Haas
EDB: http://www.enterprisedb.com