Re: [pgadmin-hackers][Patch] Bypass recovery state for Greenplum

Hi

On Fri, Jan 27, 2017 at 5:18 PM, George Gelashvili
<ggelashvili@pivotal.io> wrote:
> This bypasses checking if the DB is in recovery for versions of postgres
> that don't support pg_is_in_recovery() (anything pre-9.0, such as
> Greenplum).
>
> This patch depends on the "Refactor sql template version picking" patch.

The regression test included with this patch fail for me:

======================================================================
ERROR: runTest
(pgadmin.browser.server_groups.servers.templates.connect.sql.tests.test_check_recovery.TestCheckRecovery)
----------------------------------------------------------------------
Traceback (most recent call last):
  File
"/Users/dpage/git/pgadmin4/web/pgadmin/browser/server_groups/servers/templates/connect/sql/tests/test_check_recovery.py",
line 23, in runTest
    self.server['port']).cursor()
  File "/Users/dpage/git/pgadmin4/web/regression/test_utils.py", line
32, in get_db_connection
    port=port)
  File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/psycopg2/__init__.py",
line 164, in connect
    conn = _connect(dsn, connection_factory=connection_factory, async=async)
OperationalError: fe_sendauth: no password supplied

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company