Re: PATCH: save and restore the settings of the search objects dialog

Thanks - patch applied.

On Tue, Jul 8, 2014 at 7:28 PM, Dmitriy Olshevskiy <olshevskiy87@bk.ru> wrote:
> Hello J.F.
> Honestly, I don't sure that SaveSettings() must be called every time you
> push the Find button.
> What about the destructor method? (see the attached file)
>
> 08.07.2014 21:16, J.F. Oster пишет:
>
>> Hello,
>>
>> On Sun, Jun 22, 2014 at 11:29 AM, Dmitriy Olshevskiy <olshevskiy87@bk.ru>
>> wrote:
>>>
>>> Hello.
>>> I think it'll be useful to save the settings of search objects dialog. So
>>> I
>>> decided to add this feature.
>>> Please see the attached patch.
>>> Thank you.
>>
>> Reporting my user experience :)
>> SaveSettings() is called on Cancel button press (and Esc key press).
>> If I close the dialog with Alt-F4 or a [x] button, settings won't get
>> saved. Same situation was in dlgFindReplace.
>> Also what if call SaveSettings() in OnSearch()?
>>
> --
> Dmitriy Olshevskiy
>
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company