Re: [pgAdmin][RM4351] Confirm before close of properties dialog ifchanges not saved

Поиск
Список
Период
Сортировка
От Dave Page
Тема Re: [pgAdmin][RM4351] Confirm before close of properties dialog ifchanges not saved
Дата
Msg-id CA+OCxozd=s4vL5w8yCH2oF_ZF0mrUY3n24oCLpwSsNgfU9t7aw@mail.gmail.com
обсуждение исходный текст
Ответ на Re: [pgAdmin][RM4351] Confirm before close of properties dialog ifchanges not saved  (Dave Page <dpage@pgadmin.org>)
Ответы Re: [pgAdmin][RM4351] Confirm before close of properties dialog ifchanges not saved  (Aditya Toshniwal <aditya.toshniwal@enterprisedb.com>)
Список pgadmin-hackers
Дерево обсуждения
Hi

I just found an, umm, embarrassing issue with this. It asks for the cancel confirmation even when pressing the OK button :-o

Can you fix that ASAP please?

On Tue, Oct 29, 2019 at 2:35 PM Dave Page <dpage@pgadmin.org> wrote:
Thanks, applied.

On Tue, Oct 29, 2019 at 6:40 AM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Hackers,

Attached is the patch to warn the user before closing an unsaved properties dialog.
Additionally, I have added a preference option in Browser->Display where the user can disable this. Default is enabled.
Docs updated.

Kindly review.

--
Thanks and Regards,
Aditya Toshniwal
Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

В списке pgadmin-hackers по дате отправления:

Предыдущее
От: Dave Page
Дата:
Сообщение: Re: [pgAdmin][RM4351] Confirm before close of properties dialog ifchanges not saved
Следующее
От: Dave Page
Дата:
Сообщение: pgAdmin 4 commit: Ensure Javascript errors during Query Tool execution