Re: [pgadmin-hackers] pgAdmin 4 commit: Improve handling of nulls anddefault values in the d

Hi Dave,

Please find attached patch and review.

Also, I found an issue which logged and will work on it.

On Fri, May 12, 2017 at 5:19 PM, Surinder Kumar <surinder.kumar@enterprisedb.com> wrote:

On Fri, May 12, 2017 at 5:00 PM, Dave Page <dpage@pgadmin.org> wrote:

On Fri, May 12, 2017 at 12:19 PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:

Hi,

Below code snippet from above commit assumes that we have to disable last row after saving.

@@ -2320,6 +2340,10 @@ define(

                       grid.setSelectedRows([]);

                     }

 

+                    // Add last row(new row) to keep track of it

+                    if (is_added) {

+                      self.rows_to_disable.push(grid.getDataLength()-1);

+                    }

 However this is not the case all the time

For e.g 

Table has some data already and If user adds new row (do not save) and then copy past few exiting rows (at this point  newly added row no longer remains at last position). And after saving it disable last row which is not the newly added row.

Hmm, good point. Can you/Surinder work up a fix for that in time for the release please? 

​Sure Dave, I am working on it.​

--

Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company