Re: Problem with multiple comments

On Fri, Dec 7, 2012 at 1:14 PM, Magnus Hagander <magnus@hagander.net> wrote:
> On Thu, Dec 6, 2012 at 6:39 PM, Dave Page <dpage@pgadmin.org> wrote:
>> On Thu, Dec 6, 2012 at 11:48 AM, Magnus Hagander <magnus@hagander.net> wrote:
>>> Certainly sounds like a very similar problem. If so, the query is
>>> simply buggy - it's just that a pg_upgrade'd environment is *much*
>>> more likely to run into the problem than before.
>>>
>>> I only checked the usages of pg_shdescription. The same bug might well
>>> exist with almost all uses of pg_description.
>>
>> OK, here's a patch that should fix this, as well as Magnus' previous
>> fix which doesn't appear to have been tested so well :-p
>
> I think I'll have a hard time denying that, yes :)

:-)

>> Magnus; can you give it at least an eyeball review before I commit
>> please, in case there are any thinkos in there.
>
> So you trust my review now, even though I messed up my own one? ;)

Oddly, yes.

> But yeah, looks ok from a quick eye-over.

Thanks.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company