Re: PATCH: PGADMIN 4 - FTS templates node
| От | Dave Page |
|---|---|
| Тема | Re: PATCH: PGADMIN 4 - FTS templates node |
| Дата | |
| Msg-id | CA+OCxozUe1K9V-JF3HQ+Aj8gdEep8xhxD-GxrdkUB_k11eu55w@mail.gmail.com обсуждение исходный текст |
| Ответ на | Re: PATCH: PGADMIN 4 - FTS templates node (Sanket Mehta <sanket.mehta@enterprisedb.com>) |
| Ответы |
Re: PATCH: PGADMIN 4 - FTS templates node
|
| Список | pgadmin-hackers |
Hi
--
On Tue, Feb 23, 2016 at 1:44 PM, Sanket Mehta <sanket.mehta@enterprisedb.com> wrote:
Please do review it and if found proper please do commit it.Hi,PFA the revised patch for fts template node which includes dependency and dependent route handling code.
- When creating a new template, errors in the dialogue are not cleared - e.g. the "Name must not be empty" doesn't clear, and save is not enabled, even when a name is entered.
- "Fts Templates" should be "FTS Templates" on the treeview.
- The "Init" field should be labelled "Init Function"
- The "Lexize" field should be labelled "Lexize Function"
- Selecting a schema should be optional, with the default being the current schema.
- 4 character indents are not consistently used in SQL templates
Thanks.
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
В списке pgadmin-hackers по дате отправления: