Re: [pgAdmin][4709] Invalid FTS configuration token dictionaries
От | Dave Page |
---|---|
Тема | Re: [pgAdmin][4709] Invalid FTS configuration token dictionaries |
Дата | |
Msg-id | CA+OCxozFf0Y9thW7mSpRO8P9SCes=b9-A2ePd6gAOHTgbPfc0g@mail.gmail.com обсуждение исходный текст |
Ответ на | Re: [pgAdmin][4709] Invalid FTS configuration token dictionaries (Akshay Joshi <akshay.joshi@enterprisedb.com>) |
Ответы |
Re: [pgAdmin][4709] Invalid FTS configuration token dictionaries
|
Список | pgadmin-hackers |
Hi Akshay,
On Wed, Apr 15, 2020 at 10:42 AM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi DaveOn Wed, Apr 15, 2020 at 1:31 PM Dave Page <dpage@pgadmin.org> wrote:On Wed, Apr 15, 2020 at 8:25 AM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:Hi GaneshAs per my understanding, the dictionary names from "pg_catalog" should not be schema-qualified. Please make appropriate changes and send the patch again.@Dave/@Ashesh thoughts?Maybe I'm missing something, but I don't see why not. If anything, I'd argue it's defensive programming, that makes good sense.I am talking about showing that on GUI, please refer the below screenshot:
Yeah, we shouldn't show it in the UI. I was referring to underlying code (e.g. test cases), which should general be schema qualified where possible imho.
On Tue, Apr 14, 2020 at 5:37 PM Ganesh Jaybhay <ganesh.jaybhay@enterprisedb.com> wrote:Hi Hackers,Attached is the patch to add schema qualified dictionary names in FTS configuration to overcome the confusion of duplicate dictionary names.Also modified the resql test cases accordingly.Please review.Regards,Ganesh Jaybhay--Thanks & RegardsAkshay JoshiSr. Software ArchitectEnterpriseDB Software India Private LimitedMobile: +91 976-788-8246--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company--Thanks & RegardsAkshay JoshiSr. Software ArchitectEnterpriseDB Software India Private LimitedMobile: +91 976-788-8246
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Вложения
В списке pgadmin-hackers по дате отправления: