Re: [pgAdmin4][Patch]: Fixed RM 1603 & RM 1220
| От | Dave Page |
|---|---|
| Тема | Re: [pgAdmin4][Patch]: Fixed RM 1603 & RM 1220 |
| Дата | |
| Msg-id | CA+OCxoz8pmhgEwF-q3ob9pdOwhOL0D5hPrrpVApw1JFbgbFf6w@mail.gmail.com обсуждение исходный текст |
| Ответ на | [pgAdmin4][Patch]: Fixed RM 1603 & RM 1220 (Khushboo Vashi <khushboo.vashi@enterprisedb.com>) |
| Ответы |
Re: [pgAdmin4][Patch]: Fixed RM 1603 & RM 1220
Re: [pgAdmin4][Patch]: Fixed RM 1603 & RM 1220 |
| Список | pgadmin-hackers |
Hi
On Friday, October 14, 2016, Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
On Friday, October 14, 2016, Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
Hi,Please find the attached patch to fix the below 2 bugs.RM 1603: [Web Based] Export database failed if object contains double quotes.RM 1220: Backup database is not working with special charactersThe issues which were fixed:1. Client side data were not unescaped2. Required command line arguments were quoted twice
This is not working for me: I tested using Table Export as per Fahar's instructions. As I'm in desktop mode, the first problem was that we get an error at line 210 of import_export/__init__.py, because get_server_directory returned None for the directory. If I fix that, then the job says it's created, but as far as I can see, nothing else happens.
Secondly, this patch seems to push quoting responsibilty to the front end. This doesn't seem right, because we might want to use the RESTful APIs for another purpose in the future, which would mean needing to re-implement quoting if something else uses an affected API.
Thanks.
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
В списке pgadmin-hackers по дате отправления: