Re: [pgadmin4][Patch]: Feature #3388 Allow to set the connectiontimeout on the server properties dialog

Hi

On Tue, Jun 19, 2018 at 2:11 PM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:

Hi

On Mon, Jun 18, 2018 at 10:39 PM, Dave Page <dpage@pgadmin.org> wrote:

Hi

On Mon, Jun 18, 2018 at 12:18 PM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:

Hi Hackers,

Attached is the patch for Feature #3388 Allow to set the connection timeout on the server properties dialog. Please review it.

I took a quick look at this and had some questions/comments:

- Doc updates seem to be missing.

    My bad, again I forgot to do that. Fixed in attached patch.  

- The timeout should be passed through to external utilities like pg_dump/pg_restore.

   I am not able to see any option to set the timeout for pg_dump/pg_restore.

      Fixed it by setting environment variable "PGCONNECT_TIMEOUT". Attached is the new updated patch.
 

- Can/should the timeout be extended to the SSH tunnels?

     No option to set the timeout, I have check the sshtunnel's documentation.

- Any refactoring opportunities in the code you're touching?

    Not seen any logic that can be refactored. 

Thanks.

   Apart from above, I have found one issue in datamodel.js when setting the min value to 0 for input control, it didn't work. 

--

Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--

Akshay Joshi

Sr. Software Architect

Phone: +91 20-3058-9517
Mobile: +91 976-788-8246

--

Akshay Joshi

Sr. Software Architect

Phone: +91 20-3058-9517
Mobile: +91 976-788-8246