Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue of menuvisibility when node is hidden

Hi,

Please find updated patch with changes as per comments given by Joao.

@Joao,

Thank you for reviewing the patch.

--

Regards,

Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Thu, May 11, 2017 at 8:19 PM, Joao Pedro De Almeida Pereira <jdealmeidapereira@pivotal.io> wrote:

Hi Murtuza,

Since you are adding a new function to the browser.js component, we would encourage you to extract the function out of the templated javascript file so that it can be tested. A good example of this would be the pgadmin/static/js/size_prettify.js.

For this specific function we found one function that is used from browser.js, and you can Stub that out using 

createSpyObject(browser, 'get_preference');

We think the object here is not 100% line coverage but 100% of the behavior should be covered.

Also, suggest you change the variable name perf to preference. Looks like it is a typo.

Regards,

João & Matt 

On Thu, May 11, 2017 at 3:08 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:

Hi,

PFA patch to fix the issue where user hides the any node from Preference dialog but the menu(both context/object) still appears in pgAdmin4.

RM#2225

--

Regards,

Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers