Re: [pgAdmin4][Patch]: Fix the logic to extract the error in Query tool
| От | Dave Page |
|---|---|
| Тема | Re: [pgAdmin4][Patch]: Fix the logic to extract the error in Query tool |
| Дата | |
| Msg-id | CA+OCxoxvu1FQxhNRYYshWB9vjw=EXdRev+oWd41a1hR=NkBHmw@mail.gmail.com обсуждение исходный текст |
| Ответ на | Re: [pgAdmin4][Patch]: Fix the logic to extract the error in Query tool (Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com>) |
| Ответы |
Re: [pgAdmin4][Patch]: Fix the logic to extract the error in Query tool
|
| Список | pgadmin-hackers |
Hi
--
On Mon, Sep 18, 2017 at 3:08 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi Dave,Sorry my bad, I didn't check the backend code, I assumed that it is coming from psycopg2 and so I was focusing it to remove from client side :(PFA updated patch.
I think it needs to be a bit smarter than that. Whilst it works well for the "empty query" message, it doesn't work well for errors that have full details. For instance, instead of:
========================================================
ERROR: relation "pg_foo" does not exist
LINE 1: select * from pg_foo
^
********** Error **********
ERROR: relation "pg_foo" does not exist
SQL state: 42P01
Character: 15
========================================================
We now get:
========================================================
ERROR: ERROR: relation "pg_foo" does not exist
LINE 1: select * from pg_foo
^
ERROR: relation "pg_foo" does not exist
SQL state: 42P01
Character: 15
========================================================
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
В списке pgadmin-hackers по дате отправления: