Re: Fix PSQL Console plugin for OS X

Hi

On Fri, Mar 18, 2016 at 9:44 PM, Nicola Vitacolonna
<nvitacolonna@gmail.com> wrote:
> The PSQL Console command has been broken for a long time on OS X. Could you please fix it?
>
> This is how the command should look like:
>
> Command=/usr/bin/osascript -e 'ignoring application responses' -e 'tell application "Terminal"' -e 'activate' -e 'do
script""' -e 'do script "\'$$PGBINDIR/psql\' --host \'$$HOSTNAME\' --port $$PORT --username \'$$USERNAME\'
\'$$DATABASE\'&& exit || sleep 5 && exit" in window 1' -e 'end tell' -e 'end ignoring' 
>
> For humans:
>
> ignoring application responses
>         tell application "Terminal"
>                 do script "" -- open a new Terminal window
>                 do script "$$PGBINDIR/psql --host '$$HOSTNAME' --port $$PORT --username '$$USERNAME' '$$DATABASE' &&
exit|| sleep 5 && exit" in window 1 
>                 activate
>         end tell
> end ignoring
>
> The changes are as follows:
>
> 1) add `do script “”` to open a new Terminal window. This is necessary because in the current window there may be a
runningprocess. 

I'm not sure why you need this. I don't - I always get a new window
when using the plugin.

> 2) Remove `with command` (not wrong, but redundant).
> 3) Add `in window 1`. This is essential, otherwise the command fails.

Similarly, that's never been an issue for me.

> 4) Move `activate` at the end. This change is not strictly necessary, it is just a matter personal preference.
>
> PS: Is there a way to contribute to the code directly (à la Github)?

Please send patches (created with 'git diff') against  the repo at
http://git.postgresql.org/gitweb/?p=pgadmin3.git;a=summary. We don't
use Github.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company