Re: [FEATURE] Add schema option to all relevant objects
От | Dave Page |
---|---|
Тема | Re: [FEATURE] Add schema option to all relevant objects |
Дата | |
Msg-id | CA+OCxox_mK9uLRNpiqMFVXVWdyb1P5GquoCKNzN-xUtKdE2xqA@mail.gmail.com обсуждение исходный текст |
Ответ на | Re: [FEATURE] Add schema option to all relevant objects (Thom Brown <thom@linux.com>) |
Ответы |
Re: [FEATURE] Add schema option to all relevant objects
|
Список | pgadmin-hackers |
>> * all extension changes are wrong according to me because they aren't >> schema objects, but database objects. I don't keep them. > > The reason why I based it on schema is because I wanted it to inherit > the schema combobox object and its source for a list of schemas so > lots of redundant code could be removed. There should be no > functional difference, but I'm probably missing the point here. :) It's a misuse of the class, because it's intended to represent the schema the object is in, not one it's related to in some other way. We've made the mistake of trying to use these classes in ways that weren't intended in the past, and it's bitten us badly. I'm not keen to repeat that, for the sake of a few lines of code to store a schema name, -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
В списке pgadmin-hackers по дате отправления: