Re: [pgAdmin4][Patch]: Run MakeFile to generate builds in production mode
| От | Dave Page |
|---|---|
| Тема | Re: [pgAdmin4][Patch]: Run MakeFile to generate builds in production mode |
| Дата | |
| Msg-id | CA+OCxoxPVbmXRrBNkagkmAAWGa0FHpBXEBfgLz2+7XxQGHTjQw@mail.gmail.com обсуждение исходный текст |
| Ответ на | [pgAdmin4][Patch]: Run MakeFile to generate builds in production mode (Surinder Kumar <surinder.kumar@enterprisedb.com>) |
| Ответы |
Re: [pgAdmin4][Patch]: Run MakeFile to generate builds in production mode
|
| Список | pgadmin-hackers |
Hi
--
On Thu, Sep 7, 2017 at 7:28 AM, Surinder Kumar <surinder.kumar@enterprisedb.com> wrote:
Hi,When we run Webpack in production mode, it performs optimization on code while in development we don't optimize generated JS and CSS bundles as dev mode is for developer use.So we should run Webpack bundle in production mode when we are generating bundles for release mode.
Don't we also need a bundle target for dev mode? The patch changes "make bundle" to run "yarn run bundle:prod"
In the second patch:1) Enabled "sourced maps" in production mode as well which will help in debugging issues.2) Removed "yarn run linter" script when Webpack runs in production mode because it is for developer only to check if there are any syntax errors in JS modules.3) Removed redundant script command "yarn run bundle" as "yarn run bundle:dev" does the same thing.Please find an attached patch.Thanks,Surinder
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
В списке pgadmin-hackers по дате отправления: