Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM#2333 - Server Activitydata is not updating when server is disconnected in Dashboards

Thanks, applied.

On Wed, Apr 12, 2017 at 1:52 PM, Surinder Kumar
<surinder.kumar@enterprisedb.com> wrote:
> Hi Dave,
>
> Please find rebased patch.
>
> On Wed, Apr 12, 2017 at 5:44 PM, Dave Page <dpage@pgadmin.org> wrote:
>>
>> Can you rebase this please?
>>
>> On Tue, Apr 11, 2017 at 1:23 PM, Surinder Kumar
>> <surinder.kumar@enterprisedb.com> wrote:
>> > Hi Dave,
>> >
>> > On Tue, Apr 11, 2017 at 4:28 PM, Dave Page <dpage@pgadmin.org> wrote:
>> >>
>> >> On Tue, Apr 11, 2017 at 10:51 AM, Surinder Kumar
>> >> <surinder.kumar@enterprisedb.com> wrote:
>> >> > Hi
>> >> >
>> >> > When a server is disconnected, listen to
>> >> > 'pgadmin:server:disconnect'event
>> >> > and trigger refresh button of Server Activity data.
>> >>
>> >> I don't see any reason to do that - it's not auto-refreshed data, so
>> >> why clear it?
>> >
>> > Hmm. i agree.
>> >>
>> >>
>> >> > Also, on server disconnect, an unused event 'server-disconnected' is
>> >> > being
>> >> > triggered.
>> >> > instead it should trigger ''pgadmin:server:disconnect'event.
>> >
>> > Please find attached patch for same.
>> >>
>> >>
>> >> Please submit that as a separate cleanup patch.
>> >>
>> >> Thanks.
>> >>
>> >> --
>> >> Dave Page
>> >> Blog: http://pgsnake.blogspot.com
>> >> Twitter: @pgsnake
>> >>
>> >> EnterpriseDB UK: http://www.enterprisedb.com
>> >> The Enterprise PostgreSQL Company
>> >
>> >
>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>
>



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company