Re: [pgadmin-hackers] [pgAdmin4][Patch]: UI improvements indata-grid/query tool

Exactly what my review was going to say :-)

On Thu, Jun 8, 2017 at 3:07 PM, Sarah McAlear <smcalear@pivotal.io> wrote:
> Hi Surinder!
>
> We reviewed the patch and the changes look great. Could you change the grays
> to match the style guide?
>
> Silver, #222, and #aaa aren't listed in pgadmin.style.css.
>
> Thanks so much!
> Shirley & Sarah
>
> On Thu, Jun 8, 2017 at 9:34 AM, Surinder Kumar
> <surinder.kumar@enterprisedb.com> wrote:
>>
>> Hi,
>>
>> Changes:
>>
>> 1) Display only border-top for data-grid header instead of border on whole
>> data-grid.
>>
>> 2) Remove dotted border from cell right for consistency.
>>
>> 3) Add border-bottom for header-row so that on scroll to bottom header
>> rows are differentiated from cells.
>>
>> Also, due to these changes, the vertical scrollbar which appears at
>> data-grid right side seems to fixed.
>>
>> PFA patch and review.
>>
>>
>> Thanks,
>> Surinder
>>
>>
>> --
>> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
>> To make changes to your subscription:
>> http://www.postgresql.org/mailpref/pgadmin-hackers
>>
>



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company