Re: pgAdmin 4 v2.0-rc1 builds

On Mon, Sep 11, 2017 at 6:45 PM, Dave Page <dpage@pgadmin.org> wrote:

On Mon, Sep 11, 2017 at 2:12 PM, Surinder Kumar <surinder.kumar@enterprisedb.com> wrote:

Hi

On Mon, Sep 11, 2017 at 6:07 PM, Dave Page <dpage@pgadmin.org> wrote:

On Mon, Sep 11, 2017 at 1:18 PM, Surinder Kumar <surinder.kumar@enterprisedb.com> wrote:

Hi,

On Mon, Sep 11, 2017 at 5:40 PM, Anthony DeBarros <adebarros@gmail.com> wrote:

Howdy,

Nice work! Don’t see any show-stoppers, but I’ll throw three comments at you all.

1. New tree icons look great.

2. A few weeks back, there was a test release with a new font for the query tool. Got used to it and liked it a lot. Hope you consider using it in the future.

3. Still experiencing this bug in the History tab on MacOS: https://redmine.postgresql.org/issues/2561

​This is an issue when pgAdmin4 run/built in dev mode​. It would be resolved when pgAdmin4 built in production mode.

However, I had sent a patch to run builds in production mode. But as per discussion with Dave, we need to add another target for production mode on which I will work once i get time.

Can you get that done for tomorrow? 

​If I start working​

 

​on this tomorrow. I can add target to the build files but I am not sure it will be completed by tomorrow because it needs testing on all possible Operating Systems​ plus on runtime as well.

It it gets completed by tomorrow then I will send a patch for it, otherwise this task will require more time.

We must be thinking about this differently. Surely we just need a target that calls yarn with a different argument? 

​Yes, I think so.

​Here is my understanding:​

As per README file for mac, To create Mac bundle, we execute:

`make appbundle`​

​By default it should make build in production mode.​ But if we run it for development mode, the command should be:

`make appbundle-dev`

and target in Makefile will be:

appbundle-dev: docs

  RUN_BUILD_IN_DEV=1 ./pkg/mac/build.sh (We can use this flag to run bundle conditional)

bundle-dev:

  cd web && yarn run bundle:dev

otherwise, the default target would be:

bundle or bundle-prod:

  cd web && yarn run bundle:prod

As per README file for Windows machine, To create bundle, we execute:

"Make.bat x86|amd64"

To run it in dev mode, a flag `dev` will be passed:

`Make.bat x86|amd64 dev` (We will use `dev` flag to run bundle conditional)

Please let me know If i missed something.