Re: [pgadmin-hackers] [pgAdmin4][Patch][Feature_1535]: Pressing ESCfrom within a dialog box should act like "Cancel" button

Поиск
Список
Период
Сортировка
От Dave Page
Тема Re: [pgadmin-hackers] [pgAdmin4][Patch][Feature_1535]: Pressing ESCfrom within a dialog box should act like "Cancel" button
Дата
Msg-id CA+OCxowoRDn-pPQRwLsmWSH1fA1-9FEyt-MC8cH11KCeQvi=5g@mail.gmail.com
обсуждение исходный текст
Ответ на Re: [pgadmin-hackers] [pgAdmin4][Patch][Feature_1535]: Pressing ESCfrom within a dialog box should act like "Cancel" button  (Surinder Kumar <surinder.kumar@enterprisedb.com>)
Список pgadmin-hackers
Thanks, applied.

On Mon, Jun 12, 2017 at 3:52 PM, Surinder Kumar
<surinder.kumar@enterprisedb.com> wrote:
> Hi Dave,
>
> Please find updated patch.
>
> On Mon, Jun 12, 2017 at 7:58 PM, Dave Page <dpage@pgadmin.org> wrote:
>>
>> Hi
>>
>> On Mon, Jun 12, 2017 at 2:03 PM, Surinder Kumar
>> <surinder.kumar@enterprisedb.com> wrote:
>> > Hi
>> >
>> > I confirm this is updated patch.
>>
>> Thanks. Something else seems to have changed that I can't spot. Only
>> <return> should be ignored if a child control has focus - Escape and
>> F1 should continue to work. I tried moving the:
>>
>> if (panel && panel['_type'] !== 'node_props') return;
>>
>> into the branch for keyCode.ENTER, but that doesn't seem to help.
>
> Fixed.
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>
>



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


В списке pgadmin-hackers по дате отправления:

Предыдущее
От: Dave Page
Дата:
Сообщение: [pgadmin-hackers] pgAdmin 4 commit: Teach dialogues about Escape to cancel,Enter to Save
Следующее
От: Shruti B Iyer
Дата:
Сообщение: [pgadmin-hackers] [pgAdmin4] [PATCH] Translatable Text in QueryResults Header