Re: [pgAdmin4][Patch]: Feature #2418 add rollback and commit actionbuttons on Query Tool

Поиск
Список
Период
Сортировка
От Dave Page
Тема Re: [pgAdmin4][Patch]: Feature #2418 add rollback and commit actionbuttons on Query Tool
Дата
Msg-id CA+OCxowWES7nFHkARCKdj_A1kfoQxsQwmRi=Ku0oQ+Xc1f=5dg@mail.gmail.com
обсуждение исходный текст
Ответ на [pgAdmin4][Patch]: Feature #2418 add rollback and commit actionbuttons on Query Tool  (Akshay Joshi <akshay.joshi@enterprisedb.com>)
Ответы Re: [pgAdmin4][Patch]: Feature #2418 add rollback and commit actionbuttons on Query Tool
Список pgadmin-hackers
Дерево обсуждения
Hi

On Thu, Feb 21, 2019 at 12:40 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi Hackers,

Attached is the implementation of feature #2418 "add rollback and commit action buttons on Query Tool". I have added jasmine test cases, modified regression test. I have not added feature test as it is not stable and document is also not updated as we are going to update the new screenshots.

Please review it.

I found a few quirks:

- The buttons disable themselves after a short delay when a long running query is executed. Shouldn't we just disable them in  disable_tool_buttons()?
- The buttons are initially disabled, until a command is run. Shouldn't they return to that state after a commit or rollback (whether from a button press or typed SQL query)?
- Please update the docs, even if you don't update the screenshot (otherwise we'll forget).

Thanks.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

В списке pgadmin-hackers по дате отправления: