Re: Policy on pulling in code from other projects?

On Saturday, July 23, 2011, Christopher Browne <cbbrowne@gmail.com> wrote:
> I generally agree, Josh, but I think readline is getting pointed at a bit too much.  Yeah, it's a bad one, but we
alsoinclude other stuff like zlib that doesn't commonly come up as an issue. 
> I'd argue something just a wee bit different...
> By the time we would add in:
> - autoconf rules to detect it,
> - makefile rules to link it in
> - include file changes
> - wrappers to ensure use of pmalloc
> - Debian guys add build dependancies
> -  rpm dependencies get added
> - BSD ports dependencies
> That is likely rather more code than 1 not terribly large file of C needed to do it ourselves.  And this code is
ratherworse, as it is in a bunch of languages, spread all over. 
> If we were gaining a lot of extra functionality "for free" it would be one thing.  That is true for libssl, and
likelyzlib, but not here. 
>

Also consider if the library is widely available on common distros or
not. If not, packagers are going to have to start packaging that
first, in order to build the PostgreSQL packages. This is a *huge*
issue for use if we want to use wxWidgets addon libraries with
pgAdmin.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company