Re: Somewhat excessive version checks
От | Dave Page |
---|---|
Тема | Re: Somewhat excessive version checks |
Дата | |
Msg-id | CA+OCxow7rQVSNhfhK_6E4KUX==P9BL2M_N4K7vSddD=nyMDhLA@mail.gmail.com обсуждение исходный текст |
Ответ на | Somewhat excessive version checks (Magnus Hagander <magnus@hagander.net>) |
Ответы |
Re: Somewhat excessive version checks
|
Список | pgadmin-hackers |
On Mon, Jan 11, 2021 at 10:06 PM Magnus Hagander <magnus@hagander.net> wrote:
Hi!
If I read the code correctly, pgadmin will (unless turned off) hit the
website to check the version.json file for updates *every time it
starts*.
Every time the server starts, which is a little different, but still...
Wouldn't it make sense to rate limit that to checking say once per 24
hours maximum? Or even 48?
That certainly wouldn't be a bad idea.
It seems nobody needs the update *that* quickly, and AFAICT it does
call out to make that check synchronously on startup which means the
user is waiting.
And if/when doing that, it would be useful to include an
If-Modified-Since header on the request, so the server can just
respond with a tiny 304 reply when there is no update, which is going
to be the majority of the time. Or possibly even more efficiently,
create a custom etag and use If-None-Matches. If you make that etag be
say the version that the client has, it becomes very cheap to check
and you don't need to track any extra data.
Patches welcome!
В списке pgadmin-hackers по дате отправления: