Re: [pgAdmin4][RM#3238] Proper error handling when connection will belost to server.
| От | Dave Page |
|---|---|
| Тема | Re: [pgAdmin4][RM#3238] Proper error handling when connection will belost to server. |
| Дата | |
| Msg-id | CA+OCxow47ySKxNBTLNnbjGRSM8u7f-0Byvr7p7nDH8DX+i-7+A@mail.gmail.com обсуждение исходный текст |
| Ответ на | [pgAdmin4][RM#3238] Proper error handling when connection will belost to server. (Aditya Toshniwal <aditya.toshniwal@enterprisedb.com>) |
| Ответы |
Re: [pgAdmin4][RM#3238] Proper error handling when connection will be lost to server.
|
| Список | pgadmin-hackers |
Hi
--
On Thu, May 3, 2018 at 11:23 AM, Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Hackers,PFA patch for proper error handling when connection will be lost to server. I have created a common function alertify.pgRespErrorNotify in web/pgadmin/static/js/ alertify.pgadmin.defaults.js on the lines of existing function alertify.pgNotifier. The function is called in error callback of $.ajax call. The XHR is passed and handled in the function itself. Please note that I have used JSON.parse and not $.parseJSON as it will be deprecated in jQuery 3.x and thus removing many $.parseJSON calls. Request you to kindly review.
Can you add some appropriate tests for the new function please?
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
В списке pgadmin-hackers по дате отправления: