Re: pgAdmin Event Trigger Compatibility
От | Dave Page |
---|---|
Тема | Re: pgAdmin Event Trigger Compatibility |
Дата | |
Msg-id | CA+OCxow3m2GHtfRLK4L4A=EpEZj+hEtEddbjgz_OXnih29Zg9A@mail.gmail.com обсуждение исходный текст |
Ответ на | Re: pgAdmin Event Trigger Compatibility (Dinesh Kumar <dinesh.kumar@enterprisedb.com>) |
Список | pgadmin-hackers |
Akshay, please let me know when your review is complete and then I'll take a look.
On Mon, Jul 22, 2013 at 2:09 PM, Dinesh Kumar <dinesh.kumar@enterprisedb.com> wrote:
Hi Akshay,Thank you so much for correcting me on this. It's my bad to forgot the naming convention in the code. Now, ::OnOK() is get populating the required SQL as per the changes.Please find the new patch and let me know your valuable inputs.Dinesh
--
Dinesh KumarSoftware EngineerSkype ID: dinesh.kumar432www.enterprisedb.com
Follow us on Twitter
@EnterpriseDB
Visit EnterpriseDB for tutorials, webinars, whitepapers and moreOn Mon, Jul 22, 2013 at 5:58 PM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:Hi DineshI have just started reviewing your code and found on issue where any changes made on Event Trigger dialog won't be saved. After looking at the code, you haven't override the ::OnOK() function in dlgEventTrigger.cpp. Can you please fix this and resend the new patch.--On Wed, Jul 10, 2013 at 9:46 PM, Dinesh Kumar <dinesh.kumar@enterprisedb.com> wrote:Yes, we can change this enable check box as a radio button. But, "REPLICA/ALWAYS" are two enable's properties. Hence, We have implemented this in the proposed way. Kindly share your opinion on this.So: "Enabled Replica ( ) Enabled Always ( ) Disabled ( )" ?Yes Dave.Dinesh
--
Dinesh KumarSoftware EngineerSkype ID: dinesh.kumar432www.enterprisedb.com
Follow us on Twitter
@EnterpriseDB
Visit EnterpriseDB for tutorials, webinars, whitepapers and moreAkshay Joshi
Senior Software Engineer
EnterpriseDB Corporation
The Enterprise PostgreSQL Company
Phone: +91 20-3058-9522
Mobile: +91 976-788-8246
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
В списке pgadmin-hackers по дате отправления: