Re: [pgAdmin][RM4348] Theme options in pgAdmin and dark theme
От | Dave Page |
---|---|
Тема | Re: [pgAdmin][RM4348] Theme options in pgAdmin and dark theme |
Дата | |
Msg-id | CA+OCxow-ZLN8sKETj5Bf7Y4gTWm+q7NtugfpG3_zt-KHzpvbJA@mail.gmail.com обсуждение исходный текст |
Ответ на | Re: [pgAdmin][RM4348] Theme options in pgAdmin and dark theme (Dave Page <dpage@pgadmin.org>) |
Ответы |
Re: [pgAdmin][RM4348] Theme options in pgAdmin and dark theme
|
Список | pgadmin-hackers |
On Thu, Nov 7, 2019 at 2:18 PM Dave Page <dpage@pgadmin.org> wrote:
On Thu, Nov 7, 2019 at 1:25 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:Thanks, patch applied.On Thu, Nov 7, 2019 at 6:39 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:Hi Hackers,Attached is the updated patch with few more changes and corrections.Kindly review.I've committed a couple of minor tweaks - one to remove a space, e.g.gettext('A page refresh is required to apply the theme. Do you wish to refresh the page now ?'),
is now:gettext('A page refresh is required to apply the theme. Do you wish to refresh the page now?'),
And another change to fix the word wrapping in the README which was totally different from the rest of the file.Thanks!
Oh, and do we need all the code in config.py? I really didn't even want a config option in there to turn theming on or off (what's the point?), let alone 20 new lines.
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
В списке pgadmin-hackers по дате отправления: