Re: Wired if-statement in gen_partprune_steps_internal
От | Amit Langote |
---|---|
Тема | Re: Wired if-statement in gen_partprune_steps_internal |
Дата | |
Msg-id | CA+HiwqGd5f++NJnrmqAkUhsuMEa4APpeyCox46aYzVXadOqrwA@mail.gmail.com обсуждение исходный текст |
Ответ на | Re: Wired if-statement in gen_partprune_steps_internal (Andy Fan <zhihui.fan1213@gmail.com>) |
Список | pgsql-hackers |
Hi Andy, On Tue, Oct 20, 2020 at 4:05 PM Andy Fan <zhihui.fan1213@gmail.com> wrote: > On Wed, Oct 14, 2020 at 11:26 AM Andy Fan <zhihui.fan1213@gmail.com> wrote: >> On Mon, Oct 12, 2020 at 4:37 PM Amit Langote <amitlangote09@gmail.com> wrote: >>> I think we should remove this duplicative logic and return the >>> generated steps in a list from this function, which the code in >>> gen_partprune_steps_internal() then "combines" using an INTERSECT >>> step. See attached a patch to show what I mean. >>> >> >> This changes LGTM, and "make check" PASSED, thanks for the patch! >> > > I created https://commitfest.postgresql.org/30/2771/ so that this patch will not > be lost. Thanks! Thanks for doing that. I had updated the patch last week to address Horiguchi-san's comments but didn't manage to post a polished-enough version. I will try again this week. -- Amit Langote EDB: http://www.enterprisedb.com
В списке pgsql-hackers по дате отправления: