Re: [PATCH] hstore: Fix parsing on Mac OS X: isspace() is locale specific
| От | Evan Jones |
|---|---|
| Тема | Re: [PATCH] hstore: Fix parsing on Mac OS X: isspace() is locale specific |
| Дата | |
| Msg-id | CA+HWA9bET27MxdO4VOgK==w4P_G9H0aStCq+C_DP4YnarAw87g@mail.gmail.com обсуждение исходный текст |
| Ответ на | Re: [PATCH] hstore: Fix parsing on Mac OS X: isspace() is locale specific (Michael Paquier <michael@paquier.xyz>) |
| Ответы |
Re: [PATCH] hstore: Fix parsing on Mac OS X: isspace() is locale specific
|
| Список | pgsql-hackers |
On Tue, Jun 6, 2023 at 7:37 AM Michael Paquier <michael@paquier.xyz> wrote:
Indeed. It looks like 9ae2661 missed this spot.
I did a quick look at the places found with "git grep isspace" yesterday. I agree with the comment from commit 9ae2661: "I've left alone isspace() calls in places that aren't really expecting any non-ASCII input characters, such as float8in()." There are a number of other calls where I think it would likely be safe, and possibly even a good idea, to replace isspace() with scanner_isspace(). However, I couldn't find any where I could cause a bug like the one I hit in hstore parsing.
Original mailing list post for commit 9ae2661 in case it is helpful for others: https://www.postgresql.org/message-id/10129.1495302480@sss.pgh.pa.us
В списке pgsql-hackers по дате отправления: