Re: [PATCH] HINT: pg_hba.conf changed since last config reload

On 12/15/2014 11:38 AM, Alex Shulgin wrote:

> These are all valid concerns IMHO. Attached is the modified version of 
> the original patch by Craig, addressing the handling of the new 
> hint_log error data field and removing the client-side HINT. I'm also 
> moving this to the current CF. -- Alex
>
>


The updated patch removes the client message. I feel this addresses 
Peter's concern.  The updated patch also addresses the missing free I 
mentioned in my original review.

The patch applies cleanly to head,

One thing I'm noticed while testing is that if you do the following

1. Edit pg_hba.conf  to allow a connection from somewhere
2. Attempt to connect, you get an error + the hind in the server log
3. Make another change to pg_hba.conf and introduce an error in the file
4. Attempt to reload the config files, pg_hba.conf the reload fails 
because of the above error
5. Attempt to connect you still can't connect since we have the original 
pg_hba.conf loaded

You don't get the warning in step 5 since we update PgReloadTime even if 
the reload didn't work.

Is this enough of a concern to justify the extra complexity in tracking 
the reload time of the pg_hba and pg_ident times directly?