Re: patch for 9.2: enhanced errors

On 11-06-20 03:44 PM, Pavel Stehule wrote: <blockquote cite="mid:BANLkTik0S1kzyLFG1Pv6KhTNMqqUHh-zkA@mail.gmail.com"
type="cite"><prewrap="">Hello
 
</pre><blockquote type="cite"><pre wrap="">

You need to update config.sgml at the same time you update this format.
You need to append a "," after application name but before constraintName.
As it stands the CSV log has something like:
.....nbtinsert.c:433","psql""a_pkey","public","a","a"
</pre></blockquote><pre wrap="">
fixed

</pre></blockquote><br /> The CSV log seems fine now.<br /><br /><br /><blockquote
cite="mid:BANLkTik0S1kzyLFG1Pv6KhTNMqqUHh-zkA@mail.gmail.com"type="cite"><pre wrap=""></pre><blockquote
type="cite"><prewrap="">
 

nbtinsert.c

pg_get_indrelation is named differently than everything else in this file
(ie _bt...).  My guess is that this function belongs somewhere else but I
don't know the code well enough to say where you should move it too.

</pre></blockquote><pre wrap="">
I renamed this function to IndexRelationGetParentRelation and muved to
relcache.c

</pre></blockquote><br /> Thanks, it looks less out of place there than it did in nbtinsert.c<br /><br /><blockquote
cite="mid:BANLkTik0S1kzyLFG1Pv6KhTNMqqUHh-zkA@mail.gmail.com"type="cite"><pre wrap="">
 
I don't call a quote_identifier on only data error properties like
table_name or schema_name (but I am open to arguments for it or
against it). The quote_identifier is used for column names, because
there should be a more names and comma should be used inside name -
and this is consistent with pg_get_indexdef_columns.

Regards

</pre></blockquote><br /> Okay. <br /><br /><br /><br /><blockquote
cite="mid:BANLkTik0S1kzyLFG1Pv6KhTNMqqUHh-zkA@mail.gmail.com"type="cite"><pre wrap="">Pavel Stehule
 
</pre> <pre wrap="">
<fieldset class="mimeAttachmentHeader"></fieldset>
</pre></blockquote><br /> I'm going to mark this as ready for a committer.<br /><br /><br />