Re: [PATCH 09/14] Adjust all *Satisfies routines to take a HeapTuple instead of a HeapTupleHeader

<div class="moz-cite-prefix">On 12-11-14 08:17 PM, Andres Freund wrote:<br /></div><blockquote
cite="mid:1352942234-3953-9-git-send-email-andres@2ndquadrant.com"type="cite"><pre wrap=""> 
For the regular satisfies routines this is needed in prepareation of logical
decoding. I changed the non-regular ones for consistency as well.

The naming between htup, tuple and similar is rather confused, I could not find
any consistent naming anywhere.

This is preparatory work for the logical decoding feature which needs to be
able to get to a valid relfilenode from when checking the visibility of a
tuple.

</pre></blockquote><br /> I have taken a look at this patch.   The patch does what it says,  it changes a bunch of <br
/>HeapTupleSatisfiesXXXX routines to take a HeapTuple structure instead of a HeapTupleHeader.<br /> It also sets the
HeapTuple.t_tableOidvalue before calling these routines.<br /><br /> The patch does not modify these routines to
actuallydo anything useful with the additional data fields though it does add some assertions to make sure t_tableOid
isset.<br /><br /> The patch compiles cleanly and the unit tests pass.<br /><br /> This patch  does not seem to depend
onany of the other patches in this set and applies cleanly against master.  The patch doesn't actually add any
functionality,unless someone sees a reason for complaining about this that I don't see, then I think it can be
committed.<br/><br /> Steve<br /><br /><blockquote cite="mid:1352942234-3953-9-git-send-email-andres@2ndquadrant.com"
type="cite"><prewrap=""> 
---contrib/pgrowlocks/pgrowlocks.c      |  2 +-src/backend/access/heap/heapam.c     | 13
++++++----src/backend/access/heap/pruneheap.c | 16 ++++++++++--src/backend/catalog/index.c          |  2
+-src/backend/commands/analyze.c      |  3 ++-src/backend/commands/cluster.c       |  2
+-src/backend/commands/vacuumlazy.c   |  3 ++-src/backend/storage/lmgr/predicate.c |  2
+-src/backend/utils/time/tqual.c      | 50 +++++++++++++++++++++++++++++-------src/include/utils/snapshot.h         |
4+--src/include/utils/tqual.h            | 20 +++++++--------11 files changed, 83 insertions(+), 34 deletions(-) 

</pre><br /><fieldset class="mimeAttachmentHeader"></fieldset><br /><pre wrap="">
</pre></blockquote><br />