Re: logical changeset generation v6.2

On 09/30/2013 06:44 PM, Andres Freund wrote:
> Hi,
>
> The series from friday was a bit too buggy - obviously I was too
> tired. So here's a new one:

With this series I've also noticed
#2  0x00000000007741a7 in ExceptionalCondition (    conditionName=conditionName@entry=0x7c2908 "!(!(tuple->t_infomask &

0x1000))", errorType=errorType@entry=0x7acc70 "FailedAssertion",    fileName=fileName@entry=0x91767e "tqual.c",
lineNumber=lineNumber@entry=1608)at assert.c:54
 
54        abort();

 0x00000000007a4432 in HeapTupleSatisfiesMVCCDuringDecoding (    htup=0x10bfe48, snapshot=0x108b3d8, buffer=310) at
tqual.c:1608
#4  0x000000000049d6b7 in heap_hot_search_buffer (tid=tid@entry=0x10bfe4c,    relation=0x7fbebbcd89c0, buffer=310,
snapshot=0x10bfda0,   heapTuple=heapTuple@entry=0x10bfe48,    all_dead=all_dead@entry=0x7fff4aa3866f
"\001\370\375\v\001",   first_call=1 '\001') at heapam.c:1756
 
#5  0x00000000004a8174 in index_fetch_heap (scan=scan@entry=0x10bfdf8)    at indexam.c:539
#6  0x00000000004a82a8 in index_getnext (scan=0x10bfdf8,    direction=direction@entry=ForwardScanDirection) at
indexam.c:622
#7  0x00000000004a6fa9 in systable_getnext (sysscan=sysscan@entry=0x10bfd48)    at genam.c:343
#8  0x000000000076df40 in RelidByRelfilenode (reltablespace=0,    relfilenode=529775) at relfilenodemap.c:214
---Type <return> to continue, or q <return> to quit---
#9  0x0000000000664ad7 in ReorderBufferCommit (rb=0x1082d98,    xid=<optimized out>, commit_lsn=4638756800,
end_lsn=<optimizedout>,    commit_time=commit_time@entry=433970378426176) at reorderbuffer.c:1320
 

In addition to some of the other ones I've posted about.


> * fix pg_recvlogical makefile (Thanks Steve)
> * fix two commits not compiling properly without later changes (Thanks Kevin)
> * keep track of commit timestamps
> * fix bugs with option passing in test_logical_decoding
> * actually parse option values in test_decoding instead of just using the
>    option name
> * don't use anonymous structs in unions. That's compiler specific (msvc
>    and gcc) before C11 on which we can't rely. That unfortunately will
>    break output plugins because ReorderBufferChange need to qualify
>    old/new tuples now
> * improve error handling/cleanup in test_logical_decoding
> * some minor cleanups
>
> Patches attached, git tree updated.
>
> Greetings,
>
> Andres Freund
>
>
>