> On Thu, Mar 28, 2024 at 11:10:33PM +0100, Alvaro Herrera wrote:
> > We don't do MSVC via autoconf/Make. We used to have a special build
> > framework for MSVC which parsed Makefiles to produce "solution" files,
> > but it was removed as soon as Meson was mature enough to build. See
> > commit 1301c80b2167. If it builds with Meson, you're good.
>
> The latest cfbot build for this seems to indicate that at least newer MSVC
> knows AVX512 intrinsics without any special compiler flags [0], so maybe
> what I had in v14 is good enough. A previous version of the patch set [1] had
> the following lines:
>
> + if host_system == 'windows'
> + test_flags = ['/arch:AVX512']
> + endif
>
> I'm not sure if this is needed for older MSVC or something else. IIRC I couldn't
> find any other examples of this sort of thing in the meson scripts, either. Paul,
> do you recall why you added this?
I asked internal folks here in-the-know and they suggested I add it. I personally am not a Windows guy. If it works
withoutit and you are comfortable not including the lines, I am fine with it.
Thanks,
Paul